Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #579

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Update README #579

merged 1 commit into from
Aug 2, 2024

Conversation

cargilltay
Copy link
Contributor

Ensure example can be compiled.

Description

Existing C# example in README file could not be compiled.

  • Namespaces weren't correct.
  • There was no variable named parameters but it was passed to the Create method.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@cargilltay
Update README
5eff652 
Ensure example can be compiled.
@cargilltay cargilltay requested a review from a team August 2, 2024 00:55
@nwithan8
Copy link
Member

nwithan8 commented Aug 2, 2024

Thanks for the submission!

@jchen293 jchen293 merged commit c294e78 into EasyPost:master Aug 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cargilltay @nwithan8 @jchen293